Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean serialization #92

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Clean serialization #92

merged 10 commits into from
Sep 19, 2024

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Added deserializer and serializer components.

Related Issue(s)

None

Testing

Tested data transfer and clock counts using sequential tests for both.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

serialization.md is included in the PR.

lib/src/deserializer.dart Outdated Show resolved Hide resolved
lib/src/deserializer.dart Outdated Show resolved Hide resolved
lib/src/deserializer.dart Outdated Show resolved Hide resolved
lib/src/deserializer.dart Outdated Show resolved Hide resolved
lib/src/deserializer.dart Outdated Show resolved Hide resolved
lib/src/serializer.dart Outdated Show resolved Hide resolved
lib/src/serializer.dart Outdated Show resolved Hide resolved
lib/src/serializer.dart Outdated Show resolved Hide resolved
lib/src/serializer.dart Outdated Show resolved Hide resolved
test/serialization_test.dart Show resolved Hide resolved
@desmonddak desmonddak requested a review from mkorbel1 September 18, 2024 15:23
lib/src/serialization/deserializer.dart Outdated Show resolved Hide resolved
lib/src/serialization/deserializer.dart Show resolved Hide resolved
lib/src/serialization/serializer.dart Outdated Show resolved Hide resolved
lib/src/serialization/deserializer.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/src/serialization/serializer.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@mkorbel1 mkorbel1 merged commit 22f6154 into intel:main Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants